Postfix magic and vars #10151
Open
Postfix magic and vars #10151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Results for GUI-tests https://drone.owncloud.com/owncloud/client/13304/6/1 |
erikjv
reviewed
Sep 29, 2022
| @@ -72,7 +72,8 @@ std::shared_ptr<HBITMAP> saveImage(const string &data) | |||
| Gdiplus::GdiplusStartupInput gdiplusStartupInput; | |||
| Gdiplus::GdiplusStartup(&gdiplusToken, &gdiplusStartupInput, nullptr); | |||
|
|
|||
| DWORD size = 2 * 1024; | |||
| const int bytesPerKibibyte = 1024; | |||
| DWORD size = 2 * bytesPerKibibyte; | |||
There was a problem hiding this comment.
maybe lift my _kb operator from testchunkingng.cpp:19, put it in a utility file, and use it here?
TheOneRing
reviewed
Oct 4, 2022
| options.uplimit = it.next().toInt() * 1000; | ||
| } else if (option == QLatin1String("--downlimit") && !it.peekNext().startsWith(QLatin1String("-"))) { | ||
| options.downlimit = it.next().toInt() * 1000; | ||
| } else if (option == QLatin1String("--uplimitKbPerSec") && !it.peekNext().startsWith(QLatin1String("-"))) { |
There was a problem hiding this comment.
Please don't change the commandline arguments, the change would break existing scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution to issue #5709
Though this fix is not all encompassing to the project, I changed the variable names in files that were not static and clearly defined by use.
In regard to magic numbers, I only changed magic numbers not used in defines or function arguments.