Repository navigation
fix(deps): override js-yaml to 4.3.2 for antora collector and swagger-ui extensions - #169
Merged
Merged
Conversation
…-ui extensions @antora/collector-extension 1.0.3 and @opendevise/antora-swagger-ui-extension 1.0.0, both the latest releases, pin js-yaml ~4.1 and so install 4.1.1, which is affected by the merge-key and !!omap CPU-exhaustion advisories fixed in 4.3.0-4.3.2. No upstream release widens the range, so Dependabot cannot resolve the alerts on its own. Scope the override to those two packages and keep them on the 4.x (v4-legacy) line rather than forcing the 5.x API on them; the root js-yaml ^5.5.0 and Antora core's ~5.4 are untouched. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Thomas Müller <323649642+oc-tmueller@users.noreply.github.com>
LukasHirt
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the four open Dependabot alerts for
js-yaml(#8, #9, #10, #17 — one medium, three high): CPU-exhaustion issues in merge-key and!!omaphandling, fixed in js-yaml 4.3.0–4.3.2.Why an override
The only vulnerable copies are two nested
js-yaml@4.1.1installs, pulled in by build-time extensions that pinjs-yaml ~4.1:@antora/collector-extension@1.0.3@opendevise/antora-swagger-ui-extension@1.0.0Both are the latest releases on npm, so no upstream bump exists and Dependabot cannot resolve the alerts. The root
js-yaml ^5.5.0and Antora core (~5.4, 5.4.3) are not affected.The override is scoped to those two packages and keeps them on the 4.x (
v4-legacy) line instead of forcing the 5.x API on them. It can be dropped once upstream widens its range.Verification
npm ls js-yaml: both extensions on 4.3.2, no 4.1.x left, 5.x copies unchanged.*.yml/*.yamlfiles plus the Libre Graph OpenAPI spec the collector fetches with both 4.1.1 and 4.3.2: identical results.npm test: 39 passed, 0 failed (34 skipped).npm run buildsucceeds (760 pages indexed). Collector output (ocis/9.0/developer/_attachments/v1.0.yaml) and bothswagger-ui.htmlpages are still generated.🤖 Generated with Claude Code