-
Notifications
You must be signed in to change notification settings - Fork 191
chore(design-system, web-app-files, web-pkg, web-runtime): [OCISDEV-496] ui improvements #13341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
| "swatch-passive-contrast": "#ffffff", | ||
| "swatch-primary-default": "#4a76ac", | ||
| "swatch-primary-hover": "#80a7d7", | ||
| "swatch-primary-hover": "#164279", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This theme is not used so no need to update it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete it entirely then? it is confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already an issue for that #11328
| ] | ||
| rules: policyRules | ||
| }) | ||
| passwordPolicyMock.check.mockReturnValueOnce(passwordPolicy.pass) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
packages/design-system/src/components/OcTextInput/OcTextInput.vue
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/OcTextInputPassword/OcTextInputPassword.vue
Outdated
Show resolved
Hide resolved
|
The a11y failures should be fixed in #13349 |
|
@mzner Could you rebase this PR? |
80af529 to
93e5540
Compare
…96] ui improvements
93e5540 to
6bc56d3
Compare
|



Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: