-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linter): implement typescript/no-empty-object-type #6977
Conversation
Orenbek
commented
Oct 28, 2024
•
edited
Loading
edited
- typescript/no-empty-object-type
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
CodSpeed Performance ReportMerging #6977 will not alter performanceComparing Summary
|
crates/oxc_linter/src/rules/typescript/no_unsafe_function_type.rs
Outdated
Show resolved
Hide resolved
@camchenry Could you check it too please? Useful rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all of your work on this. I think this looks good, I think the last thing we should do is add a separate diagnostic for empty interfaces. Then this looks like it should be ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Orenbek thank you !
Merge activity
|