Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): implement typescript/no-empty-object-type #6977

Merged
merged 7 commits into from
Nov 13, 2024

Conversation

Orenbek
Copy link
Contributor

@Orenbek Orenbek commented Oct 28, 2024

Copy link

graphite-app bot commented Oct 28, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Oct 28, 2024
Copy link

codspeed-hq bot commented Oct 28, 2024

CodSpeed Performance Report

Merging #6977 will not alter performance

Comparing Orenbek:oxlint-ts_rules (422a037) with main (2268a0e)

Summary

✅ 30 untouched benchmarks

@Orenbek Orenbek changed the title feat(oxlint): add typescript lint rule no_unsafe_function_type, no_empty_object_type feat(oxlint): add typescript lint rule no_empty_object_type Oct 29, 2024
@pumano
Copy link
Contributor

pumano commented Nov 7, 2024

@camchenry Could you check it too please? Useful rule

@camc314 camc314 requested a review from DonIsaac November 7, 2024 17:02
Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks!

Copy link
Collaborator

@camchenry camchenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this. I think this looks good, I think the last thing we should do is add a separate diagnostic for empty interfaces. Then this looks like it should be ready.

Copy link
Collaborator

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Orenbek thank you !

@camc314 camc314 changed the title feat(oxlint): add typescript lint rule no_empty_object_type feat(linter): implement typescript/no-empty-object-type Nov 13, 2024
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
Copy link

graphite-app bot commented Nov 13, 2024

Merge activity

  • Nov 13, 4:30 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 4:30 AM EST: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
@camc314 camc314 merged commit 9c91151 into oxc-project:main Nov 13, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-linter Area - Linter C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants