Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(transformer): class properties transform #7011

Draft
wants to merge 33 commits into
base: 11-04-test_transformer_script_to_amend_babel_fixtures
Choose a base branch
from

Conversation

overlookmotel
Copy link
Collaborator

@overlookmotel overlookmotel commented Oct 29, 2024

WIP

Copy link

graphite-app bot commented Oct 29, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request labels Oct 29, 2024
Copy link
Collaborator Author

overlookmotel commented Oct 29, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch from 0eb3ad7 to 906e8fd Compare October 29, 2024 23:39
Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #7011 will degrade performances by 14.44%

Comparing 10-29-feat_transformer_class_properties_transform (cd8047b) with 11-04-test_transformer_script_to_amend_babel_fixtures (7b2ad89)

Summary

❌ 3 regressions
✅ 27 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark 11-04-test_transformer_script_to_amend_babel_fixtures 10-29-feat_transformer_class_properties_transform Change
transformer[antd.js] 45.4 ms 49 ms -7.27%
transformer[checker.ts] 18 ms 19.9 ms -9.47%
transformer[pdf.mjs] 6.6 ms 7.7 ms -14.44%

@overlookmotel overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 3 times, most recently from 7b2ad83 to 1f4eef9 Compare October 30, 2024 18:48
@overlookmotel overlookmotel changed the base branch from main to 10-30-test_transformer_support_exec_tests_in_oxc_folder October 30, 2024 18:48
@overlookmotel overlookmotel marked this pull request as ready for review October 30, 2024 18:49
@overlookmotel overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 2 times, most recently from 366cc8f to 65400df Compare October 30, 2024 19:59
@Boshen Boshen changed the base branch from 10-30-test_transformer_support_exec_tests_in_oxc_folder to graphite-base/7011 October 31, 2024 01:18
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much fixtures committed to this repo, let me think about #4048

@Boshen Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 5663771 to 0c69972 Compare October 31, 2024 01:26
@Boshen Boshen changed the base branch from graphite-base/7011 to main October 31, 2024 01:27
@Boshen Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 0c69972 to 3970e03 Compare October 31, 2024 01:27
@overlookmotel
Copy link
Collaborator Author

Yes, I hope there's a better solution. I just wanted some working tests while I'm building the transform.

@Boshen Boshen marked this pull request as draft October 31, 2024 09:55
Boshen pushed a commit that referenced this pull request Oct 31, 2024
Skeleton of class properties transform. #7011 contains WIP implementation.
@overlookmotel overlookmotel force-pushed the 10-29-feat_transformer_class_properties_transform branch 3 times, most recently from c71dda8 to 78b7bed Compare October 31, 2024 20:40
@overlookmotel overlookmotel changed the base branch from main to 10-31-refactor_transformer_common_vardeclarations_insert_either_var_or_let_statements October 31, 2024 20:40
@Boshen Boshen force-pushed the 10-29-feat_transformer_class_properties_transform branch from 63913ed to cd8047b Compare November 15, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ast Area - AST A-transformer Area - Transformer / Transpiler C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants