Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast): serialize StringLiterals to ESTree without raw #7263

Conversation

ottomated
Copy link
Contributor

@ottomated ottomated commented Nov 13, 2024

#7211 alternative. Makes the raw field on estree literals optional.

Copy link

graphite-app bot commented Nov 13, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

ottomated commented Nov 13, 2024

@github-actions github-actions bot added A-ast Area - AST C-enhancement Category - New feature or request labels Nov 13, 2024
@ottomated ottomated marked this pull request as ready for review November 13, 2024 07:31
Copy link

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #7263 will not alter performance

Comparing 11-12-feat_ast_serialize_stringliterals_to_estree_without_raw_ (897d3b1) with main (e84ea2c)

Summary

✅ 30 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 11-12-feat_ast_serialize_stringliterals_to_estree_without_raw_ branch from 2b44cad to 74d8b7c Compare November 13, 2024 13:33
@overlookmotel overlookmotel changed the base branch from main to 11-13-refactor_ast_move_stringliteral_definition_higher_up November 13, 2024 13:33
@overlookmotel overlookmotel changed the base branch from 11-13-refactor_ast_move_stringliteral_definition_higher_up to graphite-base/7263 November 13, 2024 13:37
Copy link
Collaborator

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

I split out moving StringLiteral definition into a separate PR #7270 to make it easier to see the substantive change here, without tons of noise in the diff.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
Copy link
Collaborator

overlookmotel commented Nov 13, 2024

Merge activity

  • Nov 13, 8:39 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 8:39 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 8:44 AM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Nov 13, 10:32 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 13, 10:36 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 13, 10:44 AM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot changed the base branch from graphite-base/7263 to main November 13, 2024 13:43
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
@overlookmotel overlookmotel force-pushed the 11-12-feat_ast_serialize_stringliterals_to_estree_without_raw_ branch from 74d8b7c to 907096d Compare November 13, 2024 15:31
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Nov 13, 2024
#7211 alternative. Makes the `raw` field on estree literals optional.
@overlookmotel overlookmotel force-pushed the 11-12-feat_ast_serialize_stringliterals_to_estree_without_raw_ branch from 907096d to 897d3b1 Compare November 13, 2024 15:37
@graphite-app graphite-app bot merged commit 897d3b1 into main Nov 13, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 11-12-feat_ast_serialize_stringliterals_to_estree_without_raw_ branch November 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants