-
Notifications
You must be signed in to change notification settings - Fork 122
New, reversible name mangling scheme #4850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
tmcgilchrist
wants to merge
54
commits into
oxcaml:name-mangling-experiments
Choose a base branch
from
tmcgilchrist:name_mangling_tsmc
base: name-mangling-experiments
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
New, reversible name mangling scheme #4850
tmcgilchrist
wants to merge
54
commits into
oxcaml:name-mangling-experiments
from
tmcgilchrist:name_mangling_tsmc
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbf07e4 to
89719d3
Compare
dbf07e4 to
3083b99
Compare
f0efca1 to
244b8bb
Compare
6970476 to
83d82ad
Compare
Since the test outputs depend on the name-mangling scheme, enable those tests only when the new scheme is enabled
Note that references to anonymous functions (in `.data`) are abbreviated to `fn` now, instead of having a file path and a location Also note that some stamps were not, and still are not, hidden as intended
On lines with multiple identifiers appearing, the `(.*)` can match, not only the body of one identifier but everything from the start of the body of the first identifier to the end of the body of the last identifier of a line
Enable the new scheme on zero-alloc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new name mangling scheme to OxCaml. The key advantage of this mangling scheme is that full module paths can be reconstructed by the de-mangler from the mangled name (i.e., including submodules and not just the compilation unit).
Remaining Todos:
De-mangling Implementations.