Skip to content

Conversation

@bemusementpark
Copy link

No description provided.

Copy link

@AL-Session AL-Session left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - will approve, but I'd sleep better knowing those two fiddly methods had been tested and we were 100% confident the functionality was the same. If you're 100% then that's good enough for me.

Log.w(TAG, "Failed to parse shared contacts.", e)
}
return emptyList()
): List<Contact> = try {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is... tricky. Would love to test that this method still works just for peace of mind.

Log.w(TAG, "Failed to parse shared contacts.", e)
}
return emptyList()
): List<LinkPreview> = try {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants