Skip to content

Bump max cpus per VM to 254 #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump max cpus per VM to 254 #2974

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/api/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ import type {
VpcFirewallRuleUpdate,
} from './__generated__/Api'

// API limits encoded in https://github.com/oxidecomputer/omicron/blob/aec3cd8d/nexus/src/app/mod.rs
// API limits encoded in https://github.com/oxidecomputer/omicron/blob/2f7f8074/nexus/src/app/mod.rs#L125-L158

export const MAX_NICS_PER_INSTANCE = 8

export const INSTANCE_MAX_CPU = 64
export const INSTANCE_MAX_CPU = 254
export const INSTANCE_MIN_RAM_GiB = 1
export const INSTANCE_MAX_RAM_GiB = 1536

Expand Down
2 changes: 1 addition & 1 deletion test/e2e/instance-create.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,7 +638,7 @@ test('Validate CPU and RAM', async ({ page }) => {

const submitButton = page.getByRole('button', { name: 'Create instance' })

const cpuMsg = page.getByText('Can be at most 64').first()
const cpuMsg = page.getByText('Can be at most 254').first()
const memMsg = page.getByText('Can be at most 1536 GiB').first()

await expect(cpuMsg).toBeHidden()
Expand Down
Loading