[bundles] Add range requests to bundle download API #8183
Conversation
smklein
changed the title
| // Note that we'll still stream data in packets which are smaller than this, | ||
| // but we won't keep a single connection to Nexus open for longer than a 100 | ||
| // MiB download. | ||
| const CHUNK_SIZE: u64 = 100 * (1 << 20); |
There was a problem hiding this comment.
If we're happy with this, I'll add something similar to the CLI once this PR merges
There was a problem hiding this comment.
Is the thought here that at some threshold we're testing our luck with regard to a timeout duration for a single query?
There was a problem hiding this comment.
Yeah, exactly, 100 MiB seems small enough to not hit our 60 sec timeout. I could change this arbitrarily, but there's a cost with setting up each stream, so I didn't want to make it too small either.
(but this is semi-arbitrary; I can tweak the value if we feel strongly)
| // Note that we'll still stream data in packets which are smaller than this, | ||
| // but we won't keep a single connection to Nexus open for longer than a 100 | ||
| // MiB download. | ||
| const CHUNK_SIZE: u64 = 100 * (1 << 20); |
There was a problem hiding this comment.
Is the thought here that at some threshold we're testing our luck with regard to a timeout duration for a single query?
#8183 plumbed range request support through Nexus for the "download entire support bundle" API. This PR continues in that direction, plumbing range request support for all other "download portions of the bundle" APIs.
This PR adds range request support to the
support_bundle_downloadendpoint in the internal and external API.It adds a
RangeRequestheader to both of these endpoints, and forwards this request to the underlying Sled Agent.Additionally, this PR updates the Sled Agent API to identify that range requests are supported. They were supported before this PR, but not encoded into the openapi spec until now.
This PR also adds: