[nexus] Use cockroachdb range stats in reconfigurator planner #8441
+267
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plotnick
reviewed
Jun 26, 2025
| pub(crate) fn zone_image_source( | ||
| &self, | ||
| zone_id: Option<OmicronZoneUuid>, |
There was a problem hiding this comment.
Can we make this parameter mandatory and always do the check in zone_should_use_new_repo? It seems confusing to have to decide at each call site whether to pass the zone_id in or not.
There was a problem hiding this comment.
Sure thing; I didn't know if the zone_id would be accessible everywhere, but it seems like it is.
Agreed this is better as a non-Optional argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.