[sled-agent] Read boot partition of M.2 drives (PR 1/2) #8450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smklein
approved these changes
Jun 25, 2025
| impl DatasetTaskHandle { | ||
| // For testing, create a handle on which requests will always fail with a | ||
| // `DatasetTaskError`. | ||
| #[cfg(any(test, feature = "testing"))] |
Collaborator
There was a problem hiding this comment.
Is this "testing" feature still being used?
Contributor
Author
There was a problem hiding this comment.
It is in other places, but this method isn't accessible outside the crate, so clippy complained about it being dead code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is basically just adding the
host_phase_2module tosled-agent-config-reconciler, which reads the boot partition of the two M.2 slots (using multiple-of-the-disk-block-size reads, which are required when accessing the raw device). The results of these reads is only logged as of this PR; the followup adds it to inventory.There are a handful of other cleanup changes that snuck in here due to dropping an out-of-date
#![allow(dead_code)].