make client-side-versioned APIs versioned #9295
Merged
+315
−389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepacheco
approved these changes
Oct 28, 2025
There was a problem hiding this comment.
I'd love @sunshowers's eyes on this as well to make sure I'm not missing something!
|
iliana
force-pushed
the
iliana/version-the-rest
branch
from
d5e904c to
3cef676
Compare
sunshowers
added a commit
that referenced
this pull request
Oct 29, 2025
Before marking this API client-side-versioned (#9295), let's ensure forward compatibility for installinator by allowing us to send more generic data over the wire. This will allow new versions of installinator to work transparently against old versions of wicketd. Wicketd does need access to structured installinator data in one spot, and we can deserialize just that part of metadata. All other data involved is just for internal bookkeeping within a service (doesn't have to transcend version boundaries), and for human consumption in the UI. There are no changes to the wire protocol, just to how it gets deserialized on the server.
iliana
changed the title
sunshowers
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8922. Makes bootstrap-agent, installinator, nexus-internal, and repo-depot versioned such that any incompatible changes are flagged.
Instead of the usual instructions for creating a new version, a strategically-positioned comment which references #9290 tells developers not to create any new versions. This comment will be visible in diffs if any versions are added.
Note that this does not add the version policy to the Dropshot listeners yet, because in currently-deployed systems the version in the header is
0.0.1. I think this should work okay during an upgrade as long as the policy isn't in place on the server side. I'll have a second PR up to add the version policy shortly, and we should merge that after systems currently performing Nexus-driven updates (only dogfood, I think?) are updated after this lands.