propolis-cli should be able to send TOML-defined CPU profiles #943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
approved these changes
Oct 24, 2025
Member
hawkw
left a comment
hawkw
left a comment
There was a problem hiding this comment.
looks good to me, picked a couple nits
bin/propolis-cli/src/main.rs
Outdated
| cfg.cpuid_profiles | ||
| .get(profile) | ||
| .ok_or_else(|| { | ||
| anyhow!("CPUID profile not defined: {}", profile) |
Member
There was a problem hiding this comment.
turbo nit
Suggested change
| anyhow!("CPUID profile not defined: {}", profile) | |
| anyhow!("CPUID profile not defined: {profile}",) |
also, maybe it would be nice to have this say "not defined in path/to/toml.toml"?
Member
Author
There was a problem hiding this comment.
i'll internalize in-line format variables one day.. i was less sure about including the toml path at first because i'd like to check the name against a the kinds of profiles we've got in Nexus (after hoisting cpu_platform.rs out of Omicron, probably), but we can change the way this error is printed when that time comes
Member
Author
|
migrate-from-base failed because this branch is from before versioned APIs and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some plumbing I wrote up to help check the CPU profile from Omicron#8728 across more OS types. I think shortly after 8728 is sorted it makes sense to move a lot of the CPUID stuff to a crate shared with Propolis, one reason being we could bake in known-to-Nexus CPUID profiles in
propolis-clias well. Then we could make--cpuid-profile milan_v1Just Work without having to copy around blobs of hex for well-defined profiles. but, this is sufficient for now.