Return the logits #127
Merged
Merged
Conversation
Contributor
Author
|
@benjaminhwilliams you were correct - cannot see a clear speed difference over multiple runs. |
benjaminhwilliams
requested changes
Mar 18, 2026
Member
benjaminhwilliams
left a comment
benjaminhwilliams
left a comment
There was a problem hiding this comment.
There are a few more opportunities to cull duplicated code from this, which would help reduce the opportunity for mistakes to creep in over time. See the suggestions for options, or adapt as you see fit. Broadly speaking though, the functionality looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag that allows users to return the logits for a per-position scoring.
Addresses RC that asks can users see which positions are not confidently scored by the model.