build(deps): remove unused hf-transfer dependency#338
Merged
Conversation
hf-transfer is declared in pyproject.toml but never activated: nothing in the codebase sets HF_HUB_ENABLE_HF_TRANSFER, and downloads go through from_pretrained / hf_hub_download with no transfer toggle. huggingface-hub is pinned ~=1.7, where Xet is the default transfer backend, so hf-transfer is dead weight and only surfaces a deprecation warning.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Owner
|
I had added However, that was before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hf-transferis declared inpyproject.tomlbut never used: nothing in the codebase setsHF_HUB_ENABLE_HF_TRANSFER, and downloads go throughfrom_pretrained/hf_hub_downloadwith no transfer toggle. Withhuggingface-hub ~= 1.7, Xet (hf-xet, already pulled in transitively) is the default accelerated backend andHF_HUB_ENABLE_HF_TRANSFERis deprecated, so the dependency is dead weight that only surfaces a deprecation warning.Validated with
uv lock,uv sync,uv run heretic --help,ruff check, andty check.