Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PEx] Correct inlining for functions returning a value #840

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

aman-goel
Copy link
Contributor

Updates include:

[PEx IR]

  • Correct how inlining works for functions returning a value
  • Adds checks for unsupported inlining, i.e., functions where return happens inside a receive case or inside a loop

Changes PEx IR to support functions that contain non-tail ending goto/raise

Enables supporting needed function inlining in spec machines

Bumps PEx runtime revision to 0.3.0
Add guard conditions to disable function body statement if already returned

Throw exception if inlining is unsupported
@aman-goel aman-goel requested a review from ChristineZh0u April 8, 2025 00:25
@ankushdesai ankushdesai merged commit 0185ff5 into inprogress/pex Apr 8, 2025
10 checks passed
@ankushdesai ankushdesai deleted the inprogress/pex_aman branch April 8, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants