Repository navigation
feat(libSceJson2): implement Object::insert - #25
Open
p3n1cillin wants to merge 1 commit into
Open
p3n1cillin wants to merge 1 commit into
p3n1cillin wants to merge 1 commit into
Conversation
Copy the pair to the end of the object and return an iterator to it, as the PS Vita sce::Json declaration in vitasdk describes. A key the object already has throws because the console's behaviour for it is unknown. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MCDdgs7PAcZLroePUFgxob
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Staged for upstream. Open it on boykopovar/AnyPS5 only after the PRs ahead of it are merged or closed (one open PR per author until one is merged).
What
Implements
sce::Json::Object::insert(const Pair&), which PPSA30601 imports (its TechnicalDebt entry listed it among six members declared without parameters).insertas a stub. The PS Vitasce::Jsondeclaration in vitasdk gives it:iterator insert(const Pair& p), returning an iterator to the inserted pair. The iterator is returned through the hidden result pointer, likeObject::begin,endandfindhere.operator[]does.insert, and the PPSA30601 entry now lists five remaining members.guest_jsoncovers the returned iterator, the copy being independent of the caller's pair, insertion order in serialization, and the duplicate-key throw leaving the object unchanged.Progress: libSceJson2 104/116 → 105/116.
Overlap: boykopovar#4476 replaces the neighbouring
Object::PairandArray::iteratorstubs in the same file and edits the same PPSA30601 TechnicalDebt line. Whichever merges second needs a trivial rebase. Neither depends on the other.Tested
Linux (Ubuntu 24.04, GCC 13.3),
BUILD_TESTING=ON:guest_jsonpasses. Removing the duplicate-key check makes it fail.python3 tools/check_conventions.py --base origin/mainpasses. No title tested.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)🤖 Generated with Claude Code
https://claude.ai/code/session_01MCDdgs7PAcZLroePUFgxob