NDP.p4 trimming switch code targetting Tofino TNA#92
Open
dragosdmtrsc wants to merge 4 commits intop4lang:masterfrom
Open
NDP.p4 trimming switch code targetting Tofino TNA#92dragosdmtrsc wants to merge 4 commits intop4lang:masterfrom
dragosdmtrsc wants to merge 4 commits intop4lang:masterfrom
Conversation
|
Hi @dragosdmtrsc, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes: ✒️ 👉 https://cla.opennetworking.org After signing, make sure to add your Github user ID For more information or help:" |
jklr
reviewed
Sep 22, 2021
Contributor
jklr
left a comment
jklr
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left a few minor comments.
| # How it works | ||
|
|
||
| To summarize, `ndp.p4` keeps an under-approximation of | ||
| the buffer occupancy for each port in ingress (by means of a |
Contributor
There was a problem hiding this comment.
suggestion: 'each port' -> 'each egress port'
| the buffer occupancy for each port in ingress (by means of a | ||
| three-color meter). Whenever the meter turns red, it means | ||
| that the buffer is full and packet undergoes trimming. To achieve | ||
| that, we mark the packet to be cloned to egress and setup |
Contributor
There was a problem hiding this comment.
'to be cloned from ingress to egress'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NDP trimming implementation targeting Tofino v1 with TNA architecture. Contents of this PR: