-
Couldn't load subscription status.
- Fork 20
Adds BND Maven Plugins #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f93b599
Adds BND Maven Plugins
ppkarwasz 3dfa3cf
Enable reproducible builds
ppkarwasz 224769c
Change module name
ppkarwasz 8c54cd7
Merge branch 'master' into feature/bnd
jeremylong 464e4c4
Merge remote-tracking branch 'package-url/master' into feature/bnd
ppkarwasz 7e988df
Make JSpecify optional
ppkarwasz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| # | ||
| # MIT License | ||
| # | ||
| # Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| # of this software and associated documentation files (the "Software"), to deal | ||
| # in the Software without restriction, including without limitation the rights | ||
| # to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| # copies of the Software, and to permit persons to whom the Software is | ||
| # furnished to do so, subject to the following conditions: | ||
| # | ||
| # The above copyright notice and this permission notice shall be included in all | ||
| # copies or substantial portions of the Software. | ||
| # | ||
| # THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| # IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| # FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| # AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| # LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| # SOFTWARE. | ||
| # | ||
| ## | ||
|
|
||
| # Create OSGi and JPMS module names based on the `groupId` and `artifactId`. | ||
| # This almost agrees with `maven-bundle-plugin`, but replaces non-alphanumeric characters | ||
| # with full stops `.`. | ||
| Bundle-SymbolicName: com.github.packageurl | ||
| -jpms-module-info: $[Bundle-SymbolicName];access=0 | ||
|
|
||
| # Convert API leakage warnings to errors | ||
| -fixupmessages.priv_refs: "private references";restrict:=warning;is:=error | ||
|
|
||
| # Options specific to dependency packages: | ||
| # | ||
| # Jakarta Validation and JSpecify are optional dependencies. | ||
| Import-Package: \ | ||
| jakarta.validation;resolution:=optional,\ | ||
| org.jspecify.annotations;resolution:=optional,\ | ||
| * | ||
|
|
||
| # Options specific to dependency modules: | ||
| # | ||
| # Optional dependencies can not be `transitive`, otherwise consumers will need them at compile time. | ||
| -jpms-module-info-options: \ | ||
| jakarta.validation;transitive=false,\ | ||
| org.jspecify;transitive=false | ||
|
|
||
| # Adds certain `Implementation-*` and `Specification-*` entries to the generated `MANIFEST.MF`. | ||
| # We set these values to their Maven Archiver defaults: https://maven.apache.org/shared/maven-archiver/#class_manifest | ||
| Implementation-Title: ${project.name} | ||
| # Implementation-Vendor: ${project.organization.name} | ||
| Implementation-Version: ${project.version} | ||
| Specification-Title: ${project.name} | ||
| # Specification-Vendor: ${project.organization.name} | ||
| Specification-Version: ${parsedVersion.majorVersion}.${parsedVersion.minorVersion} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,6 +24,8 @@ | |
| * <p><a href="https://github.com/package-url/purl-spec">https://github.com/package-url/purl-spec</a></p> | ||
| */ | ||
| @NullMarked | ||
| @Export | ||
| package com.github.packageurl; | ||
|
Comment on lines
+27
to
28
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We should likely publish the module name in the README.md. |
||
|
|
||
| import org.jspecify.annotations.NullMarked; | ||
| import org.jspecify.annotations.NullMarked; | ||
| import org.osgi.annotation.bundle.Export; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.