-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Maven support for purl2url #177
base: main
Are you sure you want to change the base?
Conversation
@fafanoulele Thanks. The thing may be a bit more complex for JARs because of the many "artefacts" available for a given version.... |
See also #179 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Here is some feedback for your consideration.
src/packageurl/contrib/purl2url.py
Outdated
name = purl_data.name | ||
version = purl_data.version | ||
|
||
base_url = "https://repo1.maven.org/maven2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you handle the case with a repository_url
qualifier that would override the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added support of repository_url
cf. 2bc0cb9
You may also want to check this by @robertguetzkow aboutcode-org/dejacode#256 (comment)
|
I've added support for
|
Add Maven support e.g.: