Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle exclusiveMinimum/exclusiveMaximum in bodies #37

Merged
merged 1 commit into from
Jul 28, 2023
Merged

fix: handle exclusiveMinimum/exclusiveMaximum in bodies #37

merged 1 commit into from
Jul 28, 2023

Conversation

vwong
Copy link
Contributor

@vwong vwong commented Jul 28, 2023 •
edited
Loading

We previously converted exclusiveMin/Max in parameters, but not in bodies. We should do it there as well.

While we're at it, we should properly handle when the value is false.

@vwong vwong requested a review from mefellows July 28, 2023 02:17
mefellows
mefellows reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@mefellows mefellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should happen if it is set to false?

lib/swagger-mock-validator/validate-spec-and-mock/validate-parsed-mock-request-body.ts Show resolved Hide resolved
@vwong
Copy link
Contributor Author

vwong commented Jul 28, 2023

If maximum is undefined, it's a noop anyway.
If exclusiveMaximum is false, it's a noop anyway

@vwong vwong merged commit fd4dee0 into master Jul 28, 2023
8 checks passed
@vwong vwong deleted the fix/exclusive-min-max branch July 28, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mefellows mefellows mefellows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwong @mefellows