-
Notifications
You must be signed in to change notification settings - Fork 4
Feat/improve webhook ecpj 182 #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stg
Are you sure you want to change the base?
Conversation
|
Por favor, catalogue-o seguindo as instruções nesta documentação. [Via VPN]. 💁 Qualquer problema ou dúvida, estamos no Slack, basta abrir um ticket no canal #help-foundation-platform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances webhook security by implementing signature validation for incoming webhook requests, as part of task ECPJ-182. The changes upgrade the core module dependency and add cryptographic verification to ensure webhook authenticity.
- Upgraded pagarme/ecommerce-module-core dependency from ~2.8.0 to ~2.9.0
- Added webhook signature validation using asymmetric cryptography
- Implemented request body validation and proper error handling for unauthorized requests
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| composer.json | Updates core module dependency to support new webhook validation features |
| Model/WebhookManagement.php | Adds signature validation logic with header verification and request body checks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Branch com conflito
Important
Certifique-se de criar o PR para a branch develop.
Tarefa ECPJ-182
Qual o tipo de PR é esse? (marque todos os aplicáveis)
Evidência
Homologação