-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Move] Partially Implement Instruct #4813
Conversation
TODO: - [ ] Still need to make in-game unit tests (i haaaaate making tests) - [ ] subsequent move calls have no messages - [ ] probably other jank i didn't fix yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Get rid of all the changes to overrides, package-lock.json
, and package.json
.
Requesting #3503 to be updated with this PR thz (Also feedback on tests is welcome - half of them are failing and IDK why) |
This comment was marked as resolved.
This comment was marked as resolved.
Btw, please don't use your fork's The best practice for dev work is to make a new branch for every PR/feature, named differently from any of the existing branches on upstream. |
I completely forgot about this when making the branch. |
Closing PR to change commit branch. |
Locales PR
What are the changes the user will see?
Instruct will actually work and calls the target's last used move correctly.
It currently does not play nice with Gigaton Hammer, Blood Moon and Torment, but those are related to the janky implementation of those moves currently. #4289
Also pledge jank happens currently.
Also the enemy cannot really use it atm but whatevs
Why am I making these changes?
Because I want funny klefki prankster instructing power trick shuckle rock slide.
What are the changes from a developer perspective?
Added
RepeatMoveAttr
for moves that force targets to repeat moves themselves. (This is distinct fromCopyMoveAttr
which has the user use a target's previous move)Screenshots/Videos
Instruct repeating an ally's rock slide & subsequently failing on enemy Unown due to not having made moves yet:
Untitled.video.-.Made.with.Clipchamp.mp4
pp after instruction
It sorta works on pledges... a bit
https://github.com/user-attachments/assets/60490c80-57bd-43cd-8d0b-66ea511803bb
Instruct fails if used on Instruct/Outrage (Full list of moves on Bulbapedia):
https://github.com/user-attachments/assets/b9a22fa2-ab67-4d1d-bd6b-81b855fa545a
https://github.com/user-attachments/assets/59e6ef89-5a7c-477e-a2d0-469ce402b5c7
How to test the changes?
Run
npm run test instruct
Checklist
beta
as my base branchnpm run test
)