Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Added failIfSingleBattle condtion to Doubles-only moves #4839

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

frutescens
Copy link
Collaborator

@frutescens frutescens commented Nov 10, 2024

What are the changes the user will see?

Helping Hand and other NearAlly moves should show a failure message.

Why am I making these changes?

I don't know either.
Note to self: Link bug report too

What are the changes from a developer perspective?

The declarations of Helping Hand and other doubles-only moves (I don't know, it's late) now has the failIfSingleCondtional

Screenshots/Videos

Screen.Recording.2024-11-10.at.12.11.41.PM.mov

How to test the changes?

Force a Pokemon to use Helping Hand in Single battle. Failure message should appear.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Are the changes visual?
    • Have I provided screenshots/videos of the changes?

@frutescens frutescens added the P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions. label Nov 10, 2024
@frutescens frutescens requested a review from a team as a code owner November 10, 2024 07:34
@DayKev DayKev added the Move Affects a move label Nov 10, 2024
@DayKev DayKev changed the title Added failIfSingleBattle condtion to Helping Hand [Bug] Added failIfSingleBattle condtion to Helping Hand Nov 10, 2024
Copy link
Collaborator

@innerthunder innerthunder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this apply to other NEAR_ALLY moves?

@frutescens
Copy link
Collaborator Author

@innerthunder I went through this list on Bulbapedia and added failIfSingleBattle conditions to them.
image

@frutescens frutescens changed the title [Bug] Added failIfSingleBattle condtion to Helping Hand [Bug] Added failIfSingleBattle condtion to Doubles-only moves Nov 10, 2024
Tempo-anon
Tempo-anon previously approved these changes Nov 10, 2024
Copy link
Collaborator

@Tempo-anon Tempo-anon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was such a simple fix for a long reported bug :goomed:

@innerthunder
Copy link
Collaborator

@innerthunder I went through this list on Bulbapedia and added failIfSingleBattle conditions to them. image

This isn't the correct list to use. Looking at Bulba's page on Follow Me:

Follow Me has no effect on moves which hit multiple Pokémon in a battle. While it can be used in Single Battles, it has no effect.

On the other hand, Coaching, another NEAR_ALLY targeting move, does fail:

If used in a Single Battle or when no ally is present, Coaching will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move P3 Bug Non gameplay affecting bug. typos, graphical issues, or other minor incorrect interactions.
Projects
None yet
4 participants