[QoL][Sprite] Set default fps to 10 instead of 12 on pokemon anim config

[pom-eranian]

Why am I making these changes?

• All the official sprites were, at some point in the past, slowed down considerably by duplicating all frames. At the same time some unofficial sprites move too fast. Lowering the framerate slightly + deleting those extra frames will get a more consistent style as a result.
• It matches the aseprite default frame duration, so the preview will by default match the final result, as it should.

What are the changes from a developer perspective?

The impressive improvement of rendering 2 less frames per second per pokemon. Tweens may vary.

Screenshots/Videos

82a2b68.mp4

Checklist

• I'm using beta as my base branch
• There is no overlap with another PR?
• The PR is self-contained and cannot be split into smaller PRs?
• Have I provided a clear explanation of the changes?
  - [ ] Have I considered writing automated tests for the issue?
  - [ ] If I have text, did I make it translatable and add a key in the English locale file(s)?
• Have I tested the changes (manually)?
  • Are all unit tests still passing? (npm run test)
• Are the changes visual?
  • Have I provided screenshots/videos of the changes?

[Tempo-anon]

Are there any other places where frameRate will need to be changed? https://github.com/search?q=repo%3Apagefaultgames%2Fpokerogue%20framerate&type=code

Will any sprite sheets need updating to account for this change?

[MokaStitcher]

This code seems to only apply to Player Pokemon, or am I misunderstanding?

pokerogue/src/field/pokemon.ts

Line 420 in 073f85c

if (this.isPlayer()) {

[pom-eranian]

Are there any other places where frameRate will need to be changed? https://github.com/search?q=repo%3Apagefaultgames%2Fpokerogue%20framerate&type=code

The change is small enough that it is almost not noticeable within the same animation.
The other places where framerate is specified do not affect pokemon sprites. A good refactor is needed :,)
EDIT: my info is outdated :,)))

Will any sprite sheets need updating to account for this change?

No. There is no framerate specified in any animation file.
However a lot of spritesheets will have to be updated at some point. Currently most of the official sprites are at 0.5 speed, compared to their official speed.

[pom-eranian]

This code seems to only apply to Player Pokemon, or am I misunderstanding?

pokerogue/src/field/pokemon.ts

Line 420 in 073f85c

if (this.isPlayer()) {

I'm glad for these reviews cause there are indeed other places where it is defined. I'm setting to draft.