[Balance] Disable King's Rock for moves that can already flinch #4860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
King's Rock should no longer activate when the holder uses a move with built-in flinch chance.
Why am I making these changes?
Requested by Balance Team. King's Rock's ability to stack with flinch effects is inaccurate to mainline and leads to the enemy becoming unable to act for several consecutive turns way too consistently.
What are the changes from a developer perspective?
phases/move-effect-phase
:MoveEffectPhase
now checks that the invoked move doesn't have aFlinchAttr
before applying King's Rock's effects.Screenshots/Videos
How to test the changes?
Finding a consistent test case may be difficult. If you try using Rock Slide/Iron Head with 3 King's Rocks, you might be able to observe that the target(s) flinch roughly 40% less often compared to before.
Checklist
beta
as my base branchnpm run test
)