Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "id" as Refs in Table of Content If Available #50

Closed
wants to merge 3 commits into from
Closed

Use "id" as Refs in Table of Content If Available #50

wants to merge 3 commits into from

Conversation

Zehua-Chen
Copy link

Implement #49

When the header already has ids specified, rather than using the header
content as refs in the table of content, use the id. Fallback to using
header content when ids are not available.

When I checkout from the master branch, script/cibuild is already failing with the following. I am not sure how to fix it.

Offenses:

jekyll-theme-leap-day.gemspec:1:1: C: Gemspec/RequiredRubyVersion: required_ruby_version should be specified.
# frozen_string_literal: true

When header already have ids specified, rather than using the header
content as refs in the table of content, use the id. Fallback to using
header content when ids are not available.
@welcome
Copy link

welcome bot commented Jun 24, 2021

Welcome! Congrats on your first pull request to the Leap Day theme. If you haven't already, please be sure to check out the contributing guidelines.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 9, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants