Feat url #10

laxman-aqw · 2025-10-27T05:54:46Z

Added URL module setup.
Implemented features to add and edit URLs.
Added a new column original_url in the urls table to:
Store the original (hashed) URL.
Prevent creation of duplicate URLs.
Integrated guards to ensure authenticated access for URL CRUD operations.
removed console
added errorhandler method to handle error
updated auth to allow user login only after verification
set expiry time in createurl
updated authguard to check userid

…heck for duplicate urls

This reverts commit a324f39.

This reverts commit 6ca753e.

arjandhakal · 2025-10-28T06:21:37Z

src/auth/auth.controller.ts

@laxman-aqw Changes to Auth seems to be out of place for this PR. Any reason for the changes here?

arjandhakal · 2025-10-28T06:22:18Z

src/email/email.controller.ts

@@ -0,0 +1,29 @@
+// import {


I think it would be better to delete the file itself

arjandhakal · 2025-10-28T06:23:23Z

src/migrations/1760522072024-createUrlTable.ts

+            CREATE TABLE "urls" (
+            "id" uuid PRIMARY KEY DEFAULT gen_random_uuid(),
+            "user_id" uuid NOT NULL,
+            "encrypted_url" varchar (2048) NOT NULL,


Do we need encrypted_url ? Can it be reconstructed using short_code if needed ?

the short_code is just a random identifier so i think we cannot.

arjandhakal · 2025-10-28T06:25:37Z

src/url/dto/create-url-request-data.ts

@@ -0,0 +1,9 @@
+import { IsNotEmpty } from 'class-validator';
+
+export class CreateUrlRequestData {


The request also needs the expiry time that the user can set

arjandhakal · 2025-10-28T06:27:17Z

src/url/url.controller.ts

+    @Req() request: RequestWithUser,
+  ) {
+    const userData = request.decodedData;
+    if (!userData) {


This should be part of validation pipeline, instead of manual check

…nto feat-cron

…to feat-url

pratham-outside · 2025-10-30T07:31:10Z

src/analytics/types.ts

+    family: string;
+    major: string;
+    minor: string;
+    patch: string;


instead of repeating this can't we make a seperate interface for this and use it ?

pratham-outside · 2025-10-30T07:42:14Z

src/auth/auth.service.ts

+    const existingUser = await this.userRepository.findOne({
+      where: [
+        { username: signUpUserDto.username },
+        { email: signUpUserDto.email },
+      ],
    });

-    if (userByUsername) {
-      throw new BadRequestException('Username already taken');
+    if (existingUser) {
+      if (existingUser.username === signUpUserDto.username) {
+        throw new BadRequestException('Username already taken');
+      }
+
+      if (existingUser.email === signUpUserDto.email) {
+        throw new BadRequestException('Email already taken');
+      }


User creation shouldn't be within user's module ?

async createUser(payload: SignupRequestData){ // here should be sign up logic }

Should be called in auth service as follows :

private readonly userService:userService this.userService.createUser()

pratham-outside · 2025-10-30T07:45:23Z

src/cron/check-url-expiry.service.ts

+      const user = await this.userRepository.findOneByOrFail({
+        id: url.userId,
+      });


rather than calling injection repostiory for user here, better create a findUserById method in user service and call user service from here

pratham-outside · 2025-10-30T07:49:53Z

src/url/dto/get-urls-request-data.ts

+export class GetUrlRequestData {
+  title: string;
+  shortCode: string;
+  expiresAt: Date;
+}


Does get ` method have request data ? Is payload allowed in get ? or is it response data ?

updated it to response

pratham-outside · 2025-10-30T07:54:22Z

src/url/url.controller.ts

+    @Req() req: RequestWithUser,
+  ) {
+    const { longCode } = await this.urlService.getLongUrl(shortCode, req);
+    return { url: longCode, statusCode: 302 };


there is a decorator to set http status in nest js , better use that above the method call. this is not a good approach

pratham-outside · 2025-10-30T07:56:25Z

src/url/url.entity.ts

+  @Column({ type: 'uuid', name: 'user_id' })
+  readonly userId: string;
+
+  @Column({ type: 'varchar', length: 2048, name: 'encrypted_url' })


if you are unsure regarding the length you can use text type

pratham-outside

Comments added . Focus on seperation of concerns

pratham-outside · 2025-10-30T10:53:56Z

src/url/url.service.ts

+    const urls = (await this.urlRepository.find({
+      where: { userId: userId },
+      select: ['title', 'shortCode', 'expiresAt'],
+    })) as GetUrlRequestData[];


Change the type name . Also can't it be urls:GetUrlRequestData[]=
Another best way might be

const urls: Pick<Url,'title'|'shortCode'|'expiresAt'>

instead a creating a new type.

pratham-outside · 2025-10-30T10:55:23Z

src/url/url.service.ts

+    if (deletedUrl.affected === 0) {
+      throw new NotFoundException('URL not found');


you have checked existence of url above and you are again checking if url is there or not here. Doesn't seem logical .

pratham-outside · 2025-10-30T10:59:05Z

src/user/user.service.ts

-      if (value === undefined || value === null) {
-        throw new BadRequestException(`Invalid value for field: ${field}`);
-      }
+    if (value === undefined || value === null) {


pratham-outside · 2025-10-30T11:01:31Z

src/migrations/1760600000000-createEmailVerificationTable.ts

The Time stamp on file and timestamp on migration class name doesn't match ????

pratham-outside · 2025-10-30T11:02:57Z

src/cron/check-url-expiry.service.ts

+      where: { expiresAt: LessThan(new Date()), expiryAlertedAt: IsNull() },
+    });
+    for (const url of expiredUrls) {
+      const user = await this.userRepository.findOneByOrFail({


findOneByOrFail throws different error in local and in production . So better use findOne and then check validation if(!user)...

pratham-outside

comments added

…up logic and user service to handle user creation logic

laxman-aqw added 16 commits October 14, 2025 10:00

WIP: url

5df2ae2

merged feat-url with fix-migration

5c1d3a8

WIP: url

4b50054

Merge branch 'feat-throttler' into feat-url

c5c5cbe

Add: Created url table migration

2920e5e

MERGE: merge with feat-throttler branch

e2c4ae7

FIX: removed unnecessary logs

67a8e87

WIP: add url modules

2ecc34c

merged with email-verification branch

7dbdae6

add original_url column in url table to store original hash url and c…

fbd42cd

…heck for duplicate urls

add url crud with guard

a324f39

Revert "add url crud with guard"

6ca753e

This reverts commit a324f39.

Reapply "add url crud with guard"

a21f934

This reverts commit 6ca753e.

removed: unnecessary codes

fb4a74f

feat(cron): added cron to send url expiry alert mail to the user

5f50cdc

feat(url_analytics): create urlAnalytics table migration

8c48d53

laxman-aqw requested review from Nijarshrestha, arjandhakal and noxiousghost October 27, 2025 06:44

laxman-aqw added the enhancement New feature or request label Oct 27, 2025

laxman-aqw self-assigned this Oct 27, 2025

laxman-aqw requested a review from pratham-outside October 27, 2025 06:46

laxman-aqw added 2 commits October 28, 2025 09:48

feat(analytics): added geoip-lite to extract geo datas

36aca8e

FIX: add browser and device column in analytics table

01914ff

arjandhakal reviewed Oct 28, 2025

View reviewed changes

Merge branch 'feat-analytics-table' into feat-analytics

e479d79

arjandhakal reviewed Oct 28, 2025

View reviewed changes

laxman-aqw added 8 commits October 29, 2025 10:32

Merge branch 'feat-cron' of github.com:pagevamp/laxman-url-shortner i…

0cf4e7b

…nto feat-cron

Merge branch 'feat-cron' into feat-url

59873e9

Merge branch 'feat-url' of github.com:pagevamp/laxman-url-shortner in…

b5f6d1a

…to feat-url

Addressed pr review changes: validated userid at authguard

869b52f

FIX: removed consoles and used error handler method to handle errors

20b17d7

FIX: Add userId in checking existing url query to avoid duplicate query

3bdafe2

FIX: removed unnecessary try catch blocks

d49fb89

removed an unnecessary migration file

41c0dd0

pratham-outside reviewed Oct 30, 2025

View reviewed changes

laxman-aqw added 2 commits October 30, 2025 14:52

fix: addressed pr review changes

72fb87a

feat(analytics): updated types and analytic service

bff9f3f

pratham-outside reviewed Oct 30, 2025

View reviewed changes

laxman-aqw added 7 commits October 31, 2025 12:11

feat(url): add redirect url request data

57a3c0b

Addressed PR review changes, updated auth service to handle only sign…

8aba362

…up logic and user service to handle user creation logic

FIX: renamed GetUrlRequestData to GetUrlResponseData

9afd588

used decorator to set http status code 302

7a6bf9c

FIX: PR review changes

d83efe2

fix: addressed pr review changes

39276c3

FIX: Addressed PR review changes

7df70b4

		@@ -0,0 +1,9 @@
		import { IsNotEmpty } from 'class-validator';

		export class CreateUrlRequestData {

		if (deletedUrl.affected === 0) {
		throw new NotFoundException('URL not found');

Feat url #10

Are you sure you want to change the base?

Feat url #10

Uh oh!

Conversation

laxman-aqw commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arjandhakal Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pratham-outside left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pratham-outside Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pratham-outside left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

laxman-aqw commented Oct 27, 2025 •

edited

Loading

arjandhakal Oct 28, 2025 •

edited

Loading

pratham-outside Oct 30, 2025 •

edited

Loading