Feat analytics filter #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
laxman-aqw
commented
Oct 31, 2025
laxman-aqw
commented
- Added os column in url analytics
- Added url filter service and end points
- updated the url record clicks service to fetch browser, device and os
- updated the url endpoint from url to urls
- added DeleteDateColumn and updated to soft delete
laxman-aqw
requested review from
Nijarshrestha,
arjandhakal,
noxiousghost and
pratham-outside
noxiousghost
approved these changes
Nov 3, 2025
|
|
||
| export class FilterAnalyticsRequestData { | ||
| @IsOptional() | ||
| browser?: string; |
Collaborator
There was a problem hiding this comment.
Suggested change
| browser?: string; | |
| browser?: string | null; |
do this for other as well
| export class UrlAnalytics { | ||
| @PrimaryGeneratedColumn('uuid') | ||
| readonly id: string; | ||
|
|
Collaborator
There was a problem hiding this comment.
add @Index here. plus explore separately what does it do
src/analytics/analytics.entity.ts
Outdated
| readonly urlId: string; | ||
|
|
||
| @Column({ type: 'varchar', length: 40, nullable: true, name: 'country' }) | ||
| readonly country: string; |
Collaborator
There was a problem hiding this comment.
Suggested change
| readonly country?: string | null; |
do this for others as well
src/analytics/analytics.entity.ts
Outdated
| readonly browser: string; | ||
|
|
||
| @Column({ type: 'varchar', length: 100, nullable: true, name: 'ip' }) | ||
| readonly ip: string; |
Collaborator
There was a problem hiding this comment.
ipAddress or ip_address would be better name here
| } | ||
| ).parse(userAgent); | ||
|
|
||
| const deviceMatch = parsed.source.match(/\(([^;]+);/); |
Collaborator
There was a problem hiding this comment.
what does that regex expression do? It's better to add in comment about it
src/analytics/analytics.service.ts
Outdated
| start: requestData.startDate, | ||
| end: requestData.endDate, | ||
| }); | ||
| } else if (requestData.startDate) { |
Collaborator
There was a problem hiding this comment.
don't use else if stick with using if statements
| "os" VARCHAR(40) , | ||
| "device" VARCHAR(50), | ||
| "browser" VARCHAR(40) , | ||
| "user_agent" VARCHAR(200), |
Collaborator
There was a problem hiding this comment.
user agents might exceed 200 character limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.