feat(user): add guards in user update #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @HttpCode(HttpStatus.OK) | ||
| @Post(':id') | ||
| @UseGuards(UserGuard) |
There was a problem hiding this comment.
if guard applies not only to this route and applies globally then you can add this above controller decorator
src/user/user.controller.ts
Outdated
| } | ||
|
|
||
| @HttpCode(HttpStatus.OK) | ||
| @Post(':id') |
There was a problem hiding this comment.
Post for update ? Shouldn't it be PATCH or PUT
src/user/user.controller.ts
Outdated
| @HttpCode(HttpStatus.CREATED) | ||
| @Post() | ||
| async createUser(@Body() body: SignupRequestData) { | ||
| return this.UserService.create(body); |
There was a problem hiding this comment.
if UserService is a class , shouldn't it be instantiated before using it within a constructor ?
Collaborator
Author
There was a problem hiding this comment.
Good catch! The variable name was incorrectly capitalized. I’ve updated it to userService
src/user/user.guards.ts
Outdated
Comment on lines
35
to
40
| if (error instanceof Error) { | ||
| throw new UnauthorizedException(error.message); | ||
| } | ||
|
|
||
| throw new UnauthorizedException('Session expired! Please sign in'); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
yes i thought i could handle like that! updated it to just return false
Collaborator
Author
There was a problem hiding this comment.
already removed try catch in branch behind
pratham-outside
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.