-
Notifications
You must be signed in to change notification settings - Fork 109
test: [IOPID-2880] add unit test on authentication folder #6896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ladirico
merged 29 commits into
master
from
IOPID-2880-add-unit-test-authentication-folder
Apr 22, 2025
Merged
test: [IOPID-2880] add unit test on authentication folder #6896
Ladirico
merged 29 commits into
master
from
IOPID-2880-add-unit-test-authentication-folder
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… folder for all section
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
shadowsheep1
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 22, 2025
…ndingScreen and refactor test login (#6904) > [!Warning] > This PR depends on #6896 ## Short description This PR introduces a new info icon in the header of the `LandingScreen`. When pressed, it opens a bottomsheet containing useful resources for the user. ## List of changes proposed in this pull request - Added an info icon to the `LandingScreen` header - Created a new bottomsheet that displays useful resources - Moved the Privacy Policy link into the bottomsheet (previously displayed directly on the `LandingScreen`) - Added links to the showcase website and account access management page - MP Events have been added on the new logic: - `LOGIN_START_FLOW_INFO` -> upon clicking on the icon that opens the bottomsheet - `LOGIN_START_FLOW_RESOURCES_TAP` -> upon clicking on links within the bottomsheet - Refactored the test login trigger logic and moved it inside the bottomsheet - Fixed tsc error caused by DS update on this file -> `ts/features/services/details/components/ServiceDetailsMetadata.tsx` ## Demo | iOS emulator | | - | | <video src="https://github.com/user-attachments/assets/b2bf6997-5209-4629-8cb7-20c473da88b1"/> | ## How to test Run the app and follow the user flow shown in the demo video. Make sure: - The info icon appears in the header of the landing screen - Tapping it opens the bottom sheet - All resources are visible and navigable - The test login flow is accessible after 5 taps on the version component --------- Co-authored-by: mariateresaventura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This pull request improves the test coverage of the authentication feature, focusing on reducers, selectors, hooks and key screens. The update includes both unit and integration tests, covering previously untested branches and edge cases.
Also, the structure of the test files has been changed to make them clearer and more understandable
How to test
To verify that the tests run successfully and coverage is correctly calculated, run the following command:
Ensure all tests pass and the coverage summary reflects the expected increase.
No app behavior should be impacted, as only test files were modified.
However, some files have been modified by adding testID, exporting functions or types, or changing names.