Skip to content

feat: [IOBP-1578] Payment webview flow #6899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Apr 17, 2025

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Apr 14, 2025

Short description

This pull request introduces significant changes to the payment authorization workflow by adding support for a web view payment flow

List of changes proposed in this pull request

  • Add walletPaymentWebViewPayloadSelector to retrieve the web view payload from the state
  • Updated the reducer to handle the new web view payment flow action and state
  • Add paymentStartWebViewFlow action to handle the start of the web view payment flow
  • Add startWebviewPaymentSession to handle webview flow
  • Update test coverage

How to test

  • Start a payment workflow with webViewPaymentFlow remote feature flag enabled
  • Initiate a payment flow within the app
  • Attempt to complete a payment
  • Verify that the app now opens the payment page in a webview

@LeleDallas LeleDallas self-assigned this Apr 14, 2025
Copy link
Contributor

github-actions bot commented Apr 14, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

@LeleDallas LeleDallas added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit f9538a5 Apr 17, 2025
22 checks passed
@LeleDallas LeleDallas deleted the IOBP-1578-payment-webview-flow branch April 17, 2025 15:56
github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2025
## ⚠️ This PR depends on #6899 

## Short description
This PR adds the header with the close action button to the new payment
webview flow.

## List of changes proposed in this pull request
- Added a custom `HeaderSecondLevel` to the payment webview screen (the
`useHeaderSecondLevel` wasn't used because it doesn't allow having only
one action);
- Added a prompt to confirm if the user really wants to exit the flow
when tapping the close button or repeatedly pressing the hardware back
button on Android.

## How to test
- Start a payment flow with the dev server started and check that the
`webViewPaymentFlow` is enabled;
- At the final payment step, ensure that a header with a close action
button is visible.
- Verify that tapping the close action button triggers an alert asking
the user to confirm whether they want to exit the flow.
- On Android devices, ensure that pressing the hardware back button
triggers the same confirmation alert as the close action button.

## Preview


https://github.com/user-attachments/assets/f67ee073-ae7d-455d-9188-fddf1f0791f2

---------

Co-authored-by: Emanuele Dall'Ara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants