Skip to content

Ignore static variables in record array field check #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shamith09 wants to merge 1 commit into
base: develop
Choose a base branch
from
+34 −1
Open

Ignore static variables in record array field check #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...error-prone/src/main/java/com/palantir/baseline/errorprone/DangerousRecordArrayField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
import com.sun.source.tree.Tree;
import com.sun.source.tree.VariableTree;
import com.sun.tools.javac.code.Symbol.ClassSymbol;
import javax.lang.model.element.Modifier;

/**
* Warns that users should not have a {@link java.util.regex.Pattern} as a key to a Set or Map.
Expand Down Expand Up @@ -65,7 +66,8 @@ public Description matchClass(ClassTree classTree, VisitorState state) {
private static boolean hasArrayField(ClassTree classTree, VisitorState state) {
for (Tree member : classTree.getMembers()) {
if (member instanceof VariableTree variableTree) {
if (IS_ARRAY_VARIABLE.matches(variableTree, state)) {
if (IS_ARRAY_VARIABLE.matches(variableTree, state)
&& !variableTree.getModifiers().getFlags().contains(Modifier.STATIC)) {
return true;
}
}
Expand Down
31 changes: 31 additions & 0 deletions ...r-prone/src/test/java/com/palantir/baseline/errorprone/DangerousRecordArrayFieldTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,4 +119,35 @@ public void testArrayInMethod() {
"}")
.doTest();
}

@Test
public void testStaticArrayFieldInRecord() {
compilationHelper
.addSourceLines(
"Test.java",
"import java.util.*;",
"import java.util.regex.Pattern;",
"class Test {",
" private record MyRecord(String name) {",
" public static byte[] STATIC_PAYLOAD = new byte[0];",
" }",
"}")
.doTest();
}

@Test
public void testStaticAndNonStaticArrayFieldInRecord() {
compilationHelper
.addSourceLines(
"Test.java",
"import java.util.*;",
"import java.util.regex.Pattern;",
"class Test {",
" // BUG: Diagnostic contains: Record type has an array field and",
" private record MyRecord(String name, byte[] payload) {",
" public static byte[] STATIC_PAYLOAD = new byte[0];",
" }",
"}")
.doTest();
}
}