break(Icon, SVGIconContainer): Update return types for React 18#7414
Merged
break(Icon, SVGIconContainer): Update return types for React 18#7414
Conversation
break(Icon, SVGIconContainer): Update return types for React 18Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
ggdouglas
previously approved these changes
Mar 28, 2025
policy-bot
Bot
dismissed
ggdouglas’s stale review
Invalidated by push of de0bc5a
ggdouglas
approved these changes
Mar 28, 2025
Merge remote-tracking branch 'origin/bp6' into js/bp6/react-18-return-typesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7350
Changes proposed in this pull request:
This PR updates the
<Icon>and<SVGIconContainer>generic components to drop React 16 support and mark theirreturn types as
React.ReactNode.Additionally, I changed the implementation of these to use arrow functions instead of
functionkeyword functions like we do elsewhere. I believe this should have no effect on the functionality, it's just for stylistic consistency and to remove a eslint override.