[fix] Fallback to string keys in maps#71
Merged
bulldozer-bot[bot] merged 1 commit intodevelopfrom Nov 20, 2018
Merged
Conversation
Contributor
|
Currently, this still means that the double keys However, once we finish defining the RFC for deduping map keys and set items we should add custom logic to dedupe keys correctly based on their conjure types. |
dansanduleac
approved these changes
Nov 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
We would generate key types by resolving the type of the key. This caused definitions with maps containing booleans and doubles as keys to generate invalid TypeScript.
After this PR
We fall back to string on any type which is not a string or an enum