Remove discussion on equality and deduplication from wire format definition#144
Conversation
|
Can we add this as an RFC as part of the same PR? |
| _ => return cmp | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
this has gotten a bit out of hand...
@iamdanfox let's chat tmr on whether it's worth speccing all of this out.
If we didn't have to deal with set deduplication (since sets can contain any other conjure type) then this would be a lot simpler
iamdanfox
changed the title
| When deserializing Conjure `set` or `map` keys, duplicate set items / map keys (according to the equivalence defined below) | ||
| are not allowed. Sets or maps containing duplicates should fail to deserialize. | ||
|
|
||
| Equivalence of two conjure values must be determined in a way that is isomorphic to comparing using the `compare` |
There was a problem hiding this comment.
TODO(dsanduleac): flesh out context for why we want this. mention typescript and go
dansanduleac
changed the title
iamdanfox
left a comment
iamdanfox
left a comment
There was a problem hiding this comment.
OK happy to remove a half-baked description with the expectation that this will be fleshed out more exhaustively in a proper RFC. (cc @uschi2000 who requested this)
|
Could you change the commit message to something more descriptive so it's to find it later? |
dansanduleac
changed the title
3 participants
To be fleshed out in #147.