Skip to content

[Demonstration] Working Conjure compiler graal native-image#780

Draft
carterkozak wants to merge 4 commits intomasterfrom
ckozak/graal
Draft

[Demonstration] Working Conjure compiler graal native-image#780
carterkozak wants to merge 4 commits intomasterfrom
ckozak/graal

Conversation

@carterkozak
Copy link
Copy Markdown
Contributor

NOT for merge

==COMMIT_MSG==
Demonstration working Conjure compiler graal native-image
==COMMIT_MSG==

Comment thread conjure/resourceconfig.json Outdated
{
"resources": {
"includes": [
{"pattern": "^(.(?!.*\\.class))*$"}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear if the .class extension exclusion is necessary, I was debugging other things.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an ideal world we'd be able to do this programatically using a build Feature like reflection to reduce dependence on custom configs.

&& !name.contains("shaded")
&& !name.contains("glassfish")
&& !name.startsWith("javax")
&& !name.startsWith("jakarta")) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was whac-a-mole.

This reduces the size from 270m to 48m

Only include reflection data for types with runtime retained
annotations, excluding several which don't have a high correlation
with reflective use (e.g. Deprecated, Documetned).
@stale
Copy link
Copy Markdown

stale Bot commented Feb 12, 2021

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

@stale stale Bot added the stale label Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant