Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

__VERSION__ is not defined #3338

Closed
clarkmoody opened this issue May 4, 2017 · 2 comments
Closed

__VERSION__ is not defined #3338

clarkmoody opened this issue May 4, 2017 · 2 comments
Labels
P0 Resolution: Fixed Type: Bug

Comments

@clarkmoody
Copy link

clarkmoody commented May 4, 2017 •
edited
Loading

Upgraded to 3.1.0 just now, and when I require('plottable') in my project, I get __VERSION__ not defined.

The browser points me to core/version.js that contains the offending line. Perhaps the sed-version task did not run properly for this build?

I'm using watchify 3.8.0 and browserify 13.1.1
@hellochar hellochar added the P0 label May 8, 2017
@hellochar
Copy link
Contributor

@clarkmoody Oof, thanks for the bug report, we really should have an automated test for that. Will get this fixed immediately...

@themadcreator themadcreator mentioned this issue May 8, 2017
Merged
@clarkmoody
Copy link
Author

Thanks! New version 3.3.1 works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P0 Resolution: Fixed Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adidahiya @hellochar @clarkmoody