Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sed version for distributable. Update version in package for patch release. #3340

Merged
merged 2 commits into from
May 8, 2017

Conversation

themadcreator
Copy link
Contributor

No description provided.

@blueprint-bot
Copy link

Sed version for distributable. Update version in package for patch release.

Demo: quicktests | fiddle

@themadcreator
Copy link
Contributor Author

Fixes #3341
Fixes #3338

Copy link
Contributor

@hellochar hellochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, can we test this stuff as part of our build somehow?

@themadcreator
Copy link
Contributor Author

themadcreator commented May 8, 2017

We really should test all release modules and artifacts. But how to test those without releasing?

@blueprint-bot
Copy link

Also fix yarn start

Demo: quicktests | fiddle

@hellochar
Copy link
Contributor

Our unit tests didn't catch this P0 because we don't have any that tests the module loading. Maybe we could add a dumb nodejs test:

// test-module-loading.js
var Plottable = require("plottable");

and run it with our build step:

// package.json
  "test-node": "node test-module-loading.js"

@themadcreator themadcreator merged commit a11d53a into develop May 8, 2017
@themadcreator themadcreator deleted the bd/sed-version branch May 8, 2017 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants