Implement SafeExceptionData util for easy SafeLoggable implementation#1172
Draft
carterkozak wants to merge 1 commit intodevelopfrom
Draft
Implement SafeExceptionData util for easy SafeLoggable implementation#1172carterkozak wants to merge 1 commit intodevelopfrom
SafeLoggable implementation#1172carterkozak wants to merge 1 commit intodevelopfrom
Conversation
Generate changelog in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proof of concept to illustrate an idea, I've only taken advantage of the new type in
SafeIllegalArgumentException.java. Is this a good idea? I'm not entirely sure yet. I don't think the existing utility functionality is terribly difficult to use, but others have voiced frustration with it.Before this PR
Our
SafeExceptions.renderMessageutil required tracking a couple additional fields in eachSafeLoggableexception. This might be a bit easier to deal with.After this PR
==COMMIT_MSG==
Implement SafeExceptionData util for easy
SafeLoggableimplementation==COMMIT_MSG==
Possible downsides?
More public API surface area