Migrate the Preconditions utility to its own package#515
Open
carterkozak wants to merge 2 commits intodevelopfrom
Open
Migrate the Preconditions utility to its own package#515carterkozak wants to merge 2 commits intodevelopfrom
carterkozak wants to merge 2 commits intodevelopfrom
Conversation
Previously preconditions reused the same package as safe-logging API, which is not allowed by the java platform module system. While this change will impact a lot of code, we can automate the transition in a relatively straightforward way, and eventualy shift the legacy jar to a runtime dependency to prevent new uses.
Generate changelog in
|
Contributor
Author
|
Moving the exceptions to their own jar makes it easier to justify adding the |
carterkozak
added a commit
to palantir/gradle-baseline
that referenced
this pull request
Jan 26, 2021
See palantir/safe-logging#515 This change does two things: * The existing errorprone checks which reference preconditions have been updated to suggest the new package name * A new `SafeLoggingPreconditionsMigration` check has been added to automatically migrate code to the new package when a sufficiently new `safe-logging` version is available.
jkozlowski
approved these changes
Jan 27, 2021
Contributor
jkozlowski
left a comment
jkozlowski
left a comment
There was a problem hiding this comment.
Let's gooo. I'm assuming there's no alternative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Previously preconditions reused the same package as safe-logging
API, which is not allowed by the java platform module system.
While this change will impact a lot of code, we can automate the
transition in a relatively straightforward way, and eventually shift
the legacy jar to a runtime dependency to prevent new uses.
After this PR
==COMMIT_MSG==
Migrate the Preconditions utility to its own
com.palantir.logsafe.preconditionspackage==COMMIT_MSG==
Possible downsides?
Deprecation warnings (or build failures) when this library is upgraded.