Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes all of the
type: ignore
mentions inArgument
, its subclasses, and theexceptions
module. To do so, the following is done:Parameter
is now an abstract base class. This just clarifies it cannot be instantiated which was always the point.Parameter.name
can no longer beNone
. It only ever isNone
whenexpose_value = False
. Instead of having to deal withNone
andis None
everywhere, let's just use""
instead ofNone
whenexpose_value
isFalse
ctx
inParameter.get_error_hint
can beNone
. It always has been like this, but wasn't explicit in typing. Better to be explicit than implicit.Add tests that demonstrate the correct behavior of the change. Testsshould fail without the change.
Parameter.name
is an implementation detail, it's not in the documentation.Add or update relevant docs, in the docs folder and in code... versionchanged::
entries in any relevant code docs.