Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid making address checksummed in test #11223

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 18, 2025

It makes the address checksummed, which is not desired, when run eslint


PR-Codex overview

This PR focuses on adding ESLint directive comments to manage linting rules around address types in the apr.test.ts file. It ensures that the tests for the getFarmApr function are correctly formatted while maintaining compliance with linting standards.

Detailed summary

  • Added /* eslint-disable address/addr-type */ before the test for getFarmApr.
  • Added /* eslint-enable address/addr-type */ after the test for getFarmApr.
  • Confirmed that the test checks both cakeRewardsApr and lpRewardsApr values.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:38am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
blog ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
bridge ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
games ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
gamification ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
uikit ⬜️ Ignored (Inspect) Feb 18, 2025 8:38am
ton ⬜️ Skipped (Inspect) Feb 18, 2025 8:38am

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: be2a361

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant