Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use predefined bignumbers to reduce memory #11226

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 18, 2025


PR-Codex overview

This PR focuses on replacing instances of new BigNumber(0) with BIG_ZERO across various files to standardize the representation of zero values. This change enhances code readability and maintains consistency.

Detailed summary

  • Replaced new BigNumber(0) with BIG_ZERO in multiple files.
  • Updated calculations and conditions to use BIG_ZERO instead of creating new BigNumber instances.
  • Ensured consistent usage of BIG_ONE and BIG_TEN where appropriate.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 18, 2025

⚠️ No Changeset found

Latest commit: 0992205

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
ton ⬜️ Skipped (Inspect) Feb 18, 2025 8:32pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant