fix: Crash when calculating mid price in swap #11240
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances error handling in the
exchange.ts
file by wrapping the calculation ofoutputAmountWithoutPriceImpact
in atry-catch
block. This ensures that if an error occurs during the calculation, it logs the error and sets a default value instead of failing silently.Detailed summary
try-catch
block around the calculation ofmidPrice
andoutputAmountWithoutPriceImpact
.catch
block, logs the error message to the console.outputAmountWithoutPriceImpact
to a default value ofCurrencyAmount.fromRawAmount(trade.outputAmount.currency, 0)
if an error occurs.