Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when calculating mid price in swap #11240

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 20, 2025


PR-Codex overview

This PR enhances error handling in the exchange.ts file by wrapping the calculation of outputAmountWithoutPriceImpact in a try-catch block. This ensures that if an error occurs during the calculation, it logs the error and sets a default value instead of failing silently.

Detailed summary

  • Added a try-catch block around the calculation of midPrice and outputAmountWithoutPriceImpact.
  • In the catch block, logs the error message to the console.
  • Sets outputAmountWithoutPriceImpact to a default value of CurrencyAmount.fromRawAmount(trade.outputAmount.currency, 0) if an error occurs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 61e443b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 10:28am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
blog ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
bridge ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
games ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
gamification ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
uikit ⬜️ Ignored (Inspect) Feb 20, 2025 10:28am
ton ⬜️ Skipped (Inspect) Feb 20, 2025 10:28am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant