Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use index lookup for warning & unspported tokens #11262

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Feb 26, 2025


PR-Codex overview

This PR focuses on optimizing the handling of unsupported and warning tokens in the useIsTransactionWarning function and refactoring the JSX structure in the AddLiquidityV3 component for better readability and maintainability.

Detailed summary

  • Updated checks for unsupportedTokens and warningTokens to directly access the token address.
  • Refactored the JSX in the AddLiquidityV3 component to improve readability by removing unnecessary fragments and restructuring the layout.
  • Maintained functionality for selecting tokens and handling different selector types.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 10eea2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 7:45am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
blog ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
bridge ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
games ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
gamification ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
uikit ⬜️ Ignored (Inspect) Visit Preview Feb 26, 2025 7:45am
ton ⬜️ Skipped (Inspect) Feb 26, 2025 7:45am

@@ -284,92 +284,88 @@ export function UniversalAddLiquidity({
}, [preferredFeeAmount, feeAmountFromUrl, handleFeePoolSelect, selectorType])

return (
<>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just removing the redundant outer div, rest is format changes

@@ -241,10 +241,10 @@ export function useIsTransactionUnsupported(currencyIn?: Currency | null, curren

// if unsupported list loaded & either token on list, mark as unsupported
if (unsupportedTokens) {
if (tokenIn && Object.keys(unsupportedTokens).includes(tokenIn.address)) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Index lookup approach is better performant (especially mobile) instead of creating keys on each render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant