Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1089 Migrate frame/series tests to new framework #1093

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft
Prev Previous commit
Next Next commit
GH1089 Partial typehinting
loicdiridollou committed Jan 16, 2025
commit ec20f776f0e6f3a99fcaafd2a19ca1002f7e2b63
3 changes: 1 addition & 2 deletions tests/test_series.py
Original file line number Diff line number Diff line change
@@ -1338,8 +1338,7 @@ def test_series_min_max_sub_axis() -> None:
check(assert_type(sa, pd.Series), pd.Series)
check(assert_type(ss, pd.Series), pd.Series)
# TODO GH1089 This should not match to Series[int]
# check(assert_type(sm, pd.Series), pd.Series)
check(assert_type(sm, "pd.Series[int]"), pd.Series, np.integer)
check(assert_type(sm, pd.Series), pd.Series, np.integer) # pyright: ignore[reportAssertTypeFailure]
check(assert_type(sd, pd.Series), pd.Series)