refactor: #718 only drop TimestampSeries

[cmp0xff]

• Addresses CLEAN: Investigate whether TimestampSeries, TimedeltaSeries, etc. can be removed #718
• Tests added: Please use assert_type() to assert the type of any return value

[Dr-Irv]

@cmp0xff you have a number of PRs submitted while I was out on vacation for 2 weeks. Can you let me know which ones I should prioritize for review?

[cmp0xff]

Hi @Dr-Irv, I hope you had a nice vacation. My pull requests are categorised below. Each category is independent, but those in a higher position have a slightly higher priority in my opinion.

Series: arithmetic operations

The following two PRs are independent. They migrate test_series.py to a subfolder series, and add quite a few test_*.py files there.

• add: feat(series): #1098 arithmetic addition #1275
• truediv: feat(series): #1098 arithmetic truediv #1280

DataFrame.to_dict

• fix(DataFrame): #799 to_dict #1283

Index.append

• feat(index): append #1282

Series: address #718

1. refactor: #718 only drop TimestampSeries #1274 - this is a prerequisite for the next one.
2. refactor: #718 also drop TimedeltaSeries #1273

[Dr-Irv]

Thanks for doing this. It's a lot of good work.

Main thing - if I'm going to merge this PR, it needs to be in a state where we don't need the followup PR.

Basic rule - we don't put ignore in the tests unless we are testing that the stubs should not accept something that is invalid. You have places where you have added ignore in the tests and I won't merge that in (unless we know it is a bug in the type checker)

[Dr-Irv]

Hi @Dr-Irv, I hope you had a nice vacation. My pull requests are categorised below. Each category is independent, but those in a higher position have a slightly higher priority in my opinion.

I've reviewed them all, except #1273 as noted there.

Thanks for all the great work.

[cmp0xff]

I've reviewed them all, except #1273 as noted there.

Thanks for all the great work.

Thank you very much for your quick and thorough reviews. I will be able to work on them next week.

[cmp0xff]

Before making this PR as "ready for review", I probably can still clean up the sub family, make some simplifications and homogenise __sub__ and sub.

[cmp0xff]

datetime - Series[Any] can either be timedelta-like or datetime-like, depending on Any. I would not give an exact type here.

[Dr-Irv]

Yes, that makes sense.

[Dr-Irv]

Use TimedeltaSeries here or TimedeltaSeries | Series[Timedelta] and then change in the PR that will remove TimedeltaSeries

[Dr-Irv]

Is it possible to combine these overloads like this?

 @overload
    def __mul__(
        self: Series[bool] | Series[int] | Series[float],
        other: timedelta | np.timedelta64 | np_ndarray_td | TimedeltaSeries,
    ) -> TimedeltaSeries: ...
    @overload
    def __mul__(self: Series[bool]  | Series[int] | Series[float],, other: Series[Timedelta]) -> Series[Timedelta]: ...  # type: ignore[overload-overlap]

[Dr-Irv]

Suggested change

	self: Series[float],
	self: Series[float] | Series[int]

And then for Series[bool], median() returns np.floating

[Dr-Irv]

I don't think you need this overload because IndexOpsMixin has it. Then you can get rid of the ignores in _SeriesSubClassBase

[Dr-Irv]

Looked at the most recent version, and found one issue, and there are a few other issues open from previous review. Ping when you want me to look at it.

[Dr-Irv]

any assert_type() within the if TYPE_CHECKING_INVALID_USAGE has to have a # type: ignore in it.

If it fails at runtime, and we can't detect it (which is the case here, I think), then just comment out the test and include a comment indicating why this can't be tested.