GH1269 Add @Final decorator to match pandas code where possible #1277
+180
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
changed the title
twoertwein
approved these changes
Jul 15, 2025
| @@ -9,9 +10,14 @@ from pandas._typing import CompressionDict | |||
| class IOHandles(Generic[AnyStr]): | |||
There was a problem hiding this comment.
I'm fairly certain this class is considered private, could remove it from the stubs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value NOTHING TO DOStill some places where
stubtestwould complain due to inheritance of the current class (like Index and DatetimeIndex).